[Skiboot] [PATCH] opal-api: Assign numbers to OPAL_MSG macros of enum opal_msg_type

Vipin K Parashar vipin at linux.vnet.ibm.com
Tue Sep 1 15:19:14 AEST 2015

On 09/01/2015 05:20 AM, Michael Ellerman wrote:
> On Tue, 2015-09-01 at 04:30 +0530, Vipin K Parashar wrote:
>> This patch assigns numbers to OPAL_MSG macros of enum opal_msg_type
>> to prevent accidental insertion of any new value in between and thus
>> break OPAL API. This is also helpful while backporting mainline kernel
>> changes to distros which run downlevel kernel and thus don't have all
>> OPAL messages defined, avoiding unnecessary bugs due to enum values
>> order mismatch.
> Does the enum buy us much? Should we just use #defines?
> Also please send a matching kernel patch.

Matching kernel patch is posted at below:


> cheers

More information about the Skiboot mailing list