[Skiboot] [PATCH] opal-api: Assign numbers to OPAL_MSG macros of enum opal_msg_type
Jeremy Kerr
jk at ozlabs.org
Tue Sep 1 12:14:43 AEST 2015
Hi Vipin,
> This patch assigns numbers to OPAL_MSG macros of enum opal_msg_type
> to prevent accidental insertion of any new value in between and thus
> break OPAL API. This is also helpful while backporting mainline kernel
> changes to distros which run downlevel kernel and thus don't have all
> OPAL messages defined, avoiding unnecessary bugs due to enum values
> order mismatch.
Looks good to me - this has caught us up previously.
Acked-by: Jeremy Kerr <jk at ozlabs.org>
mpe: The enum gives us a little more explicit type info when passing the
opal_msg_types around.
Cheers,
Jeremy
More information about the Skiboot
mailing list