[Skiboot] [PATCH] opal-api: Assign numbers to OPAL_MSG macros of enum opal_msg_type
mpe at ellerman.id.au
Tue Sep 1 09:50:30 AEST 2015
On Tue, 2015-09-01 at 04:30 +0530, Vipin K Parashar wrote:
> This patch assigns numbers to OPAL_MSG macros of enum opal_msg_type
> to prevent accidental insertion of any new value in between and thus
> break OPAL API. This is also helpful while backporting mainline kernel
> changes to distros which run downlevel kernel and thus don't have all
> OPAL messages defined, avoiding unnecessary bugs due to enum values
> order mismatch.
Does the enum buy us much? Should we just use #defines?
Also please send a matching kernel patch.
More information about the Skiboot