[Skiboot] [PATCH V3 6/6] external/pflash: Allow the libffs TOC to operate on to be specified

Alistair Popple alistair at popple.id.au
Mon Jun 1 16:40:19 AEST 2015


> It will be obvious from the output because it will print where each TOC
> is, so you'll see the --info for TOC at 0x0 and then presumably
> TOC@[side1]. But then you're probably right that someone will manage to
> get confused...

Yeah, it should be pretty obvious from the output that specifying side 
shouldn't and doesn't make a difference but someone could get confused by that 
and submit a bug report so it's probably easier to preempt that and fix it now 

> Were you thinking something in the usage text or some kind of a warning
> here? I could send a v4 of just 6/6 with added usage text...

I was thinking just a warning/error should be fine. Eg. if --side && --info 
print something like --info passed with --side. Ignoring argument to --side 
because --info shows information about all known sides.

- Alistair

More information about the Skiboot mailing list