[Skiboot] [PATCH V3 0/6] Various improvements to pflash

[Alistair Popple]

This series looks pretty good to me, assuming patches 1-4 haven't changed 
since V2.

Reviewed-By: Alistair Popple

On Fri, 22 May 2015 15:30:11 Cyril Bur wrote:
> Over time pflash has lost functionality. The introduction of two sides of
> flash on some platforms means it needs a bit of an update to handle that.
> 
> V2:
>   Move hunk from patch 1 (now patch 3) to the patch after it. Thanks Ben
>   Address bug in libffs where it didn't add the offset of the TOC to TOC
> entries.
>   Rename offset variables to toc_offset where appropriate.
>   Stewart: I don't know if you want to squash patches 1 and 2, left them
> separate.
> 
> V3:
>   Minor rework of patches 5 and 6 based on Alistair's suggestions.
>   Made --info respect --toc (patch 6)
> 
> Cyril Bur (6):
>   libffs: Rename various offset variables to toc_offset
>   libffs: Add the offset of the TOC to partition entry addresses
>   external/pflash: Report if a flash partition is ECC protected
>   external/pflash: Show the partitions on the second side flash
>   external/pflash: Perform flashing on flash sides other than side 0
>   external/pflash: Allow the libffs TOC to operate on to be specified
> 
>  external/pflash/pflash.c | 143
> +++++++++++++++++++++++++++++++++++++---------- libflash/libffs.c        | 
> 28 +++++-----
>  libflash/libffs.h        |   4 +-
>  3 files changed, 129 insertions(+), 46 deletions(-)