[Skiboot] [PATCH] flash: fix return value of flash_find_subpartition()

Cédric Le Goater clg at fr.ibm.com
Tue Feb 24 03:24:13 AEDT 2015


sparse spotted the problem :

	core/flash.c:379:22: warning: odd constant _Bool cast (fffffffffffffff6 becomes 1)

Signed-off-by: Cédric Le Goater <clg at fr.ibm.com>
---
 core/flash.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/core/flash.c b/core/flash.c
index b24ceaa24870..8461d817adae 100644
--- a/core/flash.c
+++ b/core/flash.c
@@ -359,7 +359,7 @@ static int flash_find_subpartition(struct flash_chip *chip, uint32_t subid,
 	struct flash_hostboot_header *header;
 	char eyecatcher[5];
 	uint32_t i;
-	bool rc;
+	int rc;
 
 	header = malloc(FLASH_SUBPART_HEADER_SIZE);
 	if (!header)
-- 
1.7.10.4



More information about the Skiboot mailing list