[Skiboot] [PATCH 1/2] p8/i2c: Add OPAL properties in the i2c bus nodes

Stewart Smith stewart at linux.vnet.ibm.com
Tue Feb 17 15:02:38 AEDT 2015

Neelesh Gupta <neelegup at linux.vnet.ibm.com> writes:
> On 02/13/2015 11:07 AM, Neelesh Gupta wrote:
>> We are getting the i2c device tree data from the hostboot and it
>> has i2cm nodes compatible to multiple chips like p8 and centaur.
>> The patch further adds the OPAL properties to the i2c bus nodes
>> required by the kernel.
> Oops !
> [2372303,5] [1184][p8_i2c_init]compat:ibm,power8-i2cm
> [2471907,5] [1184][p8_i2c_init]compat:ibm,power8-i2cm
> [2596869,5] [1184][p8_i2c_init]compat:ibm,centaur-i2cm
> [2683983,0] Assert fail: hw/p8-i2c.c:1185:chip
> [2789599,0] Aborting!
> I just got my hands on habanero system and assert() failed for the
> centaur chip with this change... so may be centaur chip is not present
> or if present not being added to the DT for the pnor image I tested.

Okay - I'll hold off merging then :)

More information about the Skiboot mailing list