[Skiboot] [PATCH 1/2] p8/i2c: Add OPAL properties in the i2c bus nodes

Neelesh Gupta neelegup at linux.vnet.ibm.com
Fri Feb 13 23:02:12 AEDT 2015


On 02/13/2015 11:07 AM, Neelesh Gupta wrote:
> We are getting the i2c device tree data from the hostboot and it
> has i2cm nodes compatible to multiple chips like p8 and centaur.
> The patch further adds the OPAL properties to the i2c bus nodes
> required by the kernel.

Oops !

[2372303,5] [1184][p8_i2c_init]compat:ibm,power8-i2cm
[2471907,5] [1184][p8_i2c_init]compat:ibm,power8-i2cm
[2596869,5] [1184][p8_i2c_init]compat:ibm,centaur-i2cm
[2683983,0] Assert fail: hw/p8-i2c.c:1185:chip
[2789599,0] Aborting!

I just got my hands on habanero system and assert() failed for the
centaur chip with this change... so may be centaur chip is not present
or if present not being added to the DT for the pnor image I tested.

Neelesh.

>
> Signed-off-by: Neelesh Gupta <neelegup at linux.vnet.ibm.com>
> ---
>   hw/p8-i2c.c |  263 +++++++++++++++++++++++++++++++++++------------------------
>   1 file changed, 157 insertions(+), 106 deletions(-)
>
> diff --git a/hw/p8-i2c.c b/hw/p8-i2c.c
> index 4068024..9fade5d 100644
> --- a/hw/p8-i2c.c
> +++ b/hw/p8-i2c.c
> @@ -1107,6 +1107,50 @@ void p8_i2c_interrupt(uint32_t chip_id)
>   	}
>   }
>   
>



More information about the Skiboot mailing list