[Skiboot] [PATCH 06/11] fsp-sensor: add a status property

Cedric Le Goater clg at fr.ibm.com
Tue Feb 17 05:14:05 AEDT 2015


On 02/13/2015 05:29 AM, Stewart Smith wrote:
> C├ędric Le Goater <clg at fr.ibm.com> writes:
>> We leave the decoding to the responsibility of the OS driver. This
>> is a change from the current implementation which should not add
>> too much complexity in the driver. The status bits being :
> 
> What's the compatibility with existing drivers?

The previous version returned only the FAULTED bit. the current version
returns the last three bits :

  0x0004	AC FAULTED	EM ALERT
  0x0002	FAULTED		FAULTED
  0x0001	PRESENT		PRESENT

which is handled in the linux driver to raise an alarm as it was done
before.

The device tree layout is different but the resulting functionality 
(alarm) should be the same.  

>> diff --git a/hw/dts.c b/hw/dts.c
>> index 356080e9e756..b5498d95924b 100644
>> --- a/hw/dts.c
>> +++ b/hw/dts.c
>> @@ -112,6 +112,12 @@ static int dts_read_core_temp(uint32_t pir, struct dts *dts)
>>
>>  	prlog(PR_TRACE, "DTS: Chip %x Core %x temp:%dC trip:%x\n",
>>  	      chip_id, core, dts->temp, dts->trip);
>> +
>> +	/*
>> +	 * FIXME: The trip bits are always set ?! Just discard
>> +	 * them for the moment until we understand why.
>> +	 */
>> +	dts->trip = 0;
>>  	return 0;
>>  }
> 
> Are you able to chase down this question?

The firmware team (hostboot) told me they did not use it. This is an
item we should bring up to our interlock meeting with them. Exposing 
the junction temperatures is another one.

C.

 



More information about the Skiboot mailing list