[Skiboot] [PATCH 06/11] fsp-sensor: add a status property

Stewart Smith stewart at linux.vnet.ibm.com
Fri Feb 13 15:29:50 AEDT 2015


C├ędric Le Goater <clg at fr.ibm.com> writes:
> We leave the decoding to the responsibility of the OS driver. This
> is a change from the current implementation which should not add
> too much complexity in the driver. The status bits being :

What's the compatibility with existing drivers?

> diff --git a/hw/dts.c b/hw/dts.c
> index 356080e9e756..b5498d95924b 100644
> --- a/hw/dts.c
> +++ b/hw/dts.c
> @@ -112,6 +112,12 @@ static int dts_read_core_temp(uint32_t pir, struct dts *dts)
>
>  	prlog(PR_TRACE, "DTS: Chip %x Core %x temp:%dC trip:%x\n",
>  	      chip_id, core, dts->temp, dts->trip);
> +
> +	/*
> +	 * FIXME: The trip bits are always set ?! Just discard
> +	 * them for the moment until we understand why.
> +	 */
> +	dts->trip = 0;
>  	return 0;
>  }

Are you able to chase down this question?



More information about the Skiboot mailing list