[Skiboot] [PATCH v2 1/2] include: Add PRD message definition

Stewart Smith stewart at linux.vnet.ibm.com
Thu Feb 12 17:45:53 AEDT 2015


Joel Stanley <joel at jms.id.au> writes:
>> +struct opal_prd_msg {
>> +       uint8_t         type;
>> +       uint8_t         pad[3];
>> +       uint32_t        token;
>> +       union {
>> +               struct {
>> +                       uint32_t        version;
>> +                       uint64_t        ipoll;
>> +               } init;
>> +               struct {
>> +                       uint64_t        proc;
>> +                       uint64_t        ipoll_status;
>> +                       uint64_t        ipoll_mask;
>> +               } attn;
>> +               struct {
>> +                       uint64_t        proc;
>> +                       uint64_t        ipoll_ack;
>> +               } attn_ack;
>> +               struct {
>> +                       uint64_t        chip;
>> +               } occ_error;
>> +               struct {
>> +                       uint64_t        chip;
>> +               } occ_reset;
>> +       };
>> +};
>
> Should we use __be64 and __be32 types for the integers here?

Yes, good catch - we should!



More information about the Skiboot mailing list