[Skiboot] [PATCH v2 1/2] include: Add PRD message definition

Joel Stanley joel at jms.id.au
Thu Feb 12 16:00:03 AEDT 2015


On Thu, Feb 12, 2015 at 3:09 AM, Neelesh Gupta
<neelegup at linux.vnet.ibm.com> wrote:
> From: Jeremy Kerr <jk at ozlabs.org>
>
> Signed-off-by: Jeremy Kerr <jk at ozlabs.org>
> Signed-off-by: Neelesh Gupta <neelegup at linux.vnet.ibm.com>

Reviewed-by: Joel Stanley <joel at jms.id.au>

> diff --git a/include/opal.h b/include/opal.h
> index 6c9b13a..f9f502f 100644
> --- a/include/opal.h
> +++ b/include/opal.h

> @@ -754,6 +756,43 @@ typedef struct oppanel_line {
>         uint64_t        line_len;
>  } oppanel_line_t;
>
> +enum opal_prd_msg_type {
> +       OPAL_PRD_MSG_TYPE_INIT = 0,     /* RT --> FW */
> +       OPAL_PRD_MSG_TYPE_FINI,         /* RT --> FW */
> +       OPAL_PRD_MSG_TYPE_ATTN,         /* RT <-- FW */
> +       OPAL_PRD_MSG_TYPE_ATTN_ACK,     /* RT --> FW */
> +       OPAL_PRD_MSG_TYPE_OCC_ERROR,    /* RT <-- FW */
> +       OPAL_PRD_MSG_TYPE_OCC_RESET,    /* RT <-- FW */
> +       OPAL_PRD_MSG_TYPE_MAX,
> +};

I assume FW is firmware? What is RT?

> +
> +struct opal_prd_msg {
> +       uint8_t         type;
> +       uint8_t         pad[3];
> +       uint32_t        token;
> +       union {
> +               struct {
> +                       uint32_t        version;
> +                       uint64_t        ipoll;
> +               } init;
> +               struct {
> +                       uint64_t        proc;
> +                       uint64_t        ipoll_status;
> +                       uint64_t        ipoll_mask;
> +               } attn;
> +               struct {
> +                       uint64_t        proc;
> +                       uint64_t        ipoll_ack;
> +               } attn_ack;
> +               struct {
> +                       uint64_t        chip;
> +               } occ_error;
> +               struct {
> +                       uint64_t        chip;
> +               } occ_reset;
> +       };
> +};

Should we use __be64 and __be32 types for the integers here?

> +
>  /*
>   * SG entries used for code update
>   *


More information about the Skiboot mailing list