[PATCH] arm: dts: aspeed: Enable PECI and LPC Snoop

Andrew Jeffery andrew at codeconstruct.com.au
Wed Sep 18 10:39:38 AEST 2024


Hi Manoj,

Can you please mention mentions the specific platform in the subject
(IBM System1)? Otherwise the single-line log view gives the impression
that you're enabling them for all Aspeed-based platforms.

Perhaps:

   ARM: dts: aspeed: Enable PECI and LPC snoop for IBM System1

Also, can you please send this to the upstream lists? From there I'll
backport it to the openbmc tree. `b4 prep --auto-to-cc` should help.

Andrew

On Tue, 2024-09-17 at 17:27 +0530, Manojkiran Eda via B4 Relay wrote:
> From: Manojkiran Eda <manojkiran.eda at gmail.com>
> 
> This patch enables the PECI interface and configures the LPC Snoop for
> ports 0x80 and 0x81 in the ASPEED BMC for IBM System1.
> 
> Signed-off-by: Manojkiran Eda <manojkiran.eda at gmail.com>
> ---
> This patch enables PECI and LPC snoop functionality on the IBM System1
> BMC in the device tree.
> 
> The following changes have been made:
> 
> 1. Enabled the PECI controller (peci0) by marking its status to "okay".
> 2. Enabled the LPC snoop engine, configuring snoop ports at 0x80 and
>    0x81.
> 
> These changes are required to support PECI communication and LPC
> snooping for system monitoring and debugging purposes.
> ---
>  arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts
> index cb3063413d1f..738a86c787c0 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts
> @@ -464,6 +464,15 @@ &kcs3 {
>  	aspeed,lpc-interrupts = <11 IRQ_TYPE_LEVEL_LOW>;
>  };
>  
> +&peci0 {
> +	status = "okay";
> +};
> +
> +&lpc_snoop {
> +	status = "okay";
> +	snoop-ports = <0x80>, <0x81>;
> +};
> +
>  &i2c0 {
>  	status = "okay";
>  
> 
> ---
> base-commit: ca2478a7d974f38d29d27acb42a952c7f168916e
> change-id: 20240917-dts-aspeed-system1-peci-snoop-725c70f4a485
> 
> Best regards,



More information about the openbmc mailing list