Virtual Media repository request
przemyslaw.hawrylewicz.czarnowski at linux.intel.com
Thu Dec 9 19:56:55 AEDT 2021
On 08.12.2021 17:56, Patrick Williams wrote:
> On Tue, Dec 07, 2021 at 03:50:47PM +0000, Hawrylewicz Czarnowski, Przemyslaw wrote:
> Hello Przemyslaw,
> Thank you for wanting to work at getting this code mainlined. I know there has
> been quite a bit of interest from various people outside Intel.
>> I would like to request for new Virtual Media service repository (based on the design document located here: https://github.com/openbmc/docs/blob/master/designs/virtual-media.md).
> I know you've got a pending commit to update some pieces of this design. Since
> none of the code has been submitted since the design was originally written, do
> we need anyone to re-read it and see if anything has changed in the rest of the
> codebase that needs design updates?
The code base for VM is "live" at the moment and besides
asynchronousness nothing needs to be updated at the moment.
There is a limitation for DVD iso's which lies in USB gadget and how it
is implemented, so maybe there could be some kind of note about that.
>> The service itself is a reworked Virtual Media which early stage is available here: https://github.com/Intel-BMC/provingground.
> What did you have in mind for maintainer structure on this? I'd ideally like to
> see someone outside of Intel be a co-maintainer with you since:
> - This code was initially written as experimental Intel-only repository
> without any community feedback and
> - The current code hasn't been touched in 2 years and best practices have
> likely changed.
> - You're not currently a maintainer on any other repositories.
The code base exposed in provingground was under the development at that
moment and actually shouldn't be submitted. The code is updated now
(still needs some polishing I suppose) but I am ready to push updated
sources and ask the community to review it.
Right now I am the main person for VM in Intel, but actually I was
thinking about some co-maintainership in case there are other parties
willing to have contribution in the code. This could be worked out
during review process.
>> And additional question: is there anything to do in order to enable CI for this repo?
> Once the repository is set up, Andrew G can enable CI on it fairly quickly.
Glad to hear that.
More information about the openbmc