[entity-manager]Should I add min,max to legacy.json?
Scron Chang (張仲延)
Scron.Chang at quantatw.com
Thu Dec 31 14:37:34 AEDT 2020
Thanks for your reply.
I has submitted a commit, and here is the link
Please take a look. Thanks again.
From: Ed Tanous <ed at tanous.net>
Sent: Tuesday, December 29, 2020 2:29 AM
To: Scron Chang (張仲延) <Scron.Chang at quantatw.com>
Cc: openbmc at lists.ozlabs.org
Subject: Re: [entity-manager]Should I add min,max to legacy.json?
On Mon, Dec 28, 2020 at 5:57 AM Scron Chang (張仲延)
<Scron.Chang at quantatw.com> wrote:
> Hi all,
> In my case, lots of dbus-sensors/PSUSensor are using. Refer to the hint in PSUSensorMain.cpp L576 to define the value of maximum/minimum, lots of objects like vout1_max, iout1_min… are defined in my configuration file. Even though it works (check by ipmitool sensor command), this json data can't pass to entity-manager/scripts/validate-configs.py. The reason should be there are no objects of PSU sensors' maximum and minimum in entity-manager/schema/legacy.json. Should I directly add those maximum and minimum objects to schema/legacy.json and submit schema/legacy.json to upstream?
I missed this in a recent code review to dbus sensors (I thought that interface already existed); Yes, please do the above.
> I would appreciate any suggestions.
> Scron Chang
> E-Mail Scron.Chang at quantatw.com
> Ext. 11936
More information about the openbmc