[entity-manager]Should I add min,max to legacy.json?

Ed Tanous ed at tanous.net
Tue Dec 29 05:28:40 AEDT 2020

On Mon, Dec 28, 2020 at 5:57 AM Scron Chang (張仲延)
<Scron.Chang at quantatw.com> wrote:
> Hi all,
>   In my case, lots of dbus-sensors/PSUSensor are using. Refer to the hint in PSUSensorMain.cpp L576 to define the value of maximum/minimum, lots of objects like vout1_max, iout1_min… are defined in my configuration file. Even though it works (check by ipmitool sensor command), this json data can't pass to entity-manager/scripts/validate-configs.py. The reason should be there are no objects of PSU sensors' maximum and minimum in entity-manager/schema/legacy.json. Should I directly add those maximum and minimum objects to schema/legacy.json and submit schema/legacy.json to upstream?

I missed this in a recent code review to dbus sensors (I thought that
interface already existed);  Yes, please do the above.

> Ref: https://github.com/openbmc/dbus-sensors/blob/23c96e7c249b41efecc10ba7acba82603a54b996/src/PSUSensorMain.cpp#L576
> I would appreciate any suggestions.
> Scron Chang
> E-Mail  Scron.Chang at quantatw.com
> Ext.    11936

More information about the openbmc mailing list