[PATCH linux dev-4.13 3/5] ARM: dts: aspeed-g5: Add resets and clocks to GFX node

[Joel Stanley]

On 19 April 2018 at 15:23, Andrew Jeffery <andrew at aj.id.au> wrote:
> On Thu, 19 Apr 2018, at 13:50, Joel Stanley wrote:
>> The ast2500 has a reset for the CRT device that must be deasserted
>> before it can be used. Similarly it has a clock gate for a clock called
>> D1CLK that must be set to running.
>>
>> Signed-off-by: Joel Stanley <joel at jms.id.au>
>> ---
>>  arch/arm/boot/dts/aspeed-g5.dtsi | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi b/arch/arm/boot/dts/aspeed-g5.dtsi
>> index 25a88dd44d91..4ca4bc463347 100644
>> --- a/arch/arm/boot/dts/aspeed-g5.dtsi
>> +++ b/arch/arm/boot/dts/aspeed-g5.dtsi
>> @@ -175,6 +175,10 @@
>>                               compatible = "aspeed,ast2500-gfx", "syscon";
>>                               reg = <0x1e6e6000 0x1000>;
>>                               reg-io-width = <4>;
>> +                             clocks = <&syscon ASPEED_CLK_GATE_D1CLK>;
>> +                             resets = <&syscon ASPEED_RESET_CRT1>;
>> +                             status = "disabled";
>> +                             interrupts = <0x19>;
>
> Bit of a nit, but it would be easier to reference the documentation if the interrupt was base 10...

I'm not sure why they are hex. I'd take an upstream patch to change
them all over to base 10.

>
> Reviewed-by: Andrew Jeffery <andrew at aj.id.au>

Thanks for reviewing.

Cheers,

Joel