[PATCH linux dev-4.10 v3] ARM: dts: aspeed: quanta: Enable pwm fans

[Mykola Kostenok]

Hi!


We want to add pwm_tacho for msn platform too.

Is there some special reason why you add pwm_tacho: pwm-tacho-controller at 1e786000  to .dts not .dtsi file?


What about add this:

       pwm_tacho: pwm-tacho-controller at 1e786000 {
               #address-cells = <1>;
               #size-cells = <1>;
              reg = <0x1e786000 0x1000>;
               compatible = "aspeed,ast2500-pwm-tacho";
               clocks = <&pwm_tacho_fixed_clk>;
               pinctrl-names = "default";


to aspeed-g5.dtsi?


And specific like pinctrl and fan:

               pinctrl-0 = <&pinctrl_pwm0_default &pinctrl_pwm1_default
                       &pinctrl_pwm2_default &pinctrl_pwm3_default>;

               fan at 0 {
                       reg = <0x00>;
                       aspeed,fan-tach-ch = /bits/ 8 <0x00>;
               };


 to .dts file.


Thanks.

Best regards, Mykola Kostenok.

________________________________
От: openbmc <openbmc-bounces+c_mykolak=mellanox.com at lists.ozlabs.org> от имени Patrick Venture <venture at google.com>
Отправлено: 28 июня 2017 г. 17:23:04
Кому: venture at google.com; joel at jms.id.au; openbmc at lists.ozlabs.org
Тема: [PATCH linux dev-4.10 v3] ARM: dts: aspeed: quanta: Enable pwm fans

Signed-off-by: Patrick Venture <venture at google.com>
---
v3: lowercased hex address
v2: Moved pwm_tacho_fixed_clk to clocks.
---
 arch/arm/boot/dts/aspeed-bmc-quanta-q71l.dts | 51 ++++++++++++++++++++++++++++
 arch/arm/boot/dts/aspeed-g4.dtsi             |  5 +++
 2 files changed, 56 insertions(+)

diff --git a/arch/arm/boot/dts/aspeed-bmc-quanta-q71l.dts b/arch/arm/boot/dts/aspeed-bmc-quanta-q71l.dts
index e609c53d58f5..3abc2954d26e 100644
--- a/arch/arm/boot/dts/aspeed-bmc-quanta-q71l.dts
+++ b/arch/arm/boot/dts/aspeed-bmc-quanta-q71l.dts
@@ -46,6 +46,57 @@
                         gpios = <&gpio ASPEED_GPIO(B, 3) GPIO_ACTIVE_LOW>;
                 };
         };
+
+       pwm_tacho: pwm-tacho-controller at 1e786000 {
+               #address-cells = <1>;
+               #size-cells = <1>;
+               reg = <0x1e786000 0x1000>;
+               compatible = "aspeed,ast2500-pwm-tacho";
+               clocks = <&pwm_tacho_fixed_clk>;
+               pinctrl-names = "default";
+               pinctrl-0 = <&pinctrl_pwm0_default &pinctrl_pwm1_default
+                       &pinctrl_pwm2_default &pinctrl_pwm3_default>;
+
+               fan at 0 {
+                       reg = <0x00>;
+                       aspeed,fan-tach-ch = /bits/ 8 <0x00>;
+               };
+
+               fan at 1 {
+                       reg = <0x01>;
+                       aspeed,fan-tach-ch = /bits/ 8 <0x01>;
+               };
+
+               fan at 2 {
+                       reg = <0x02>;
+                       aspeed,fan-tach-ch = /bits/ 8 <0x02>;
+               };
+
+               fan at 3 {
+                       reg = <0x03>;
+                       aspeed,fan-tach-ch = /bits/ 8 <0x03>;
+               };
+
+               fan at 4 {
+                       reg = <0x00>;
+                       aspeed,fan-tach-ch = /bits/ 8 <0x04>;
+               };
+
+               fan at 5 {
+                       reg = <0x01>;
+                       aspeed,fan-tach-ch = /bits/ 8 <0x05>;
+               };
+
+               fan at 6 {
+                       reg = <0x02>;
+                       aspeed,fan-tach-ch = /bits/ 8 <0x06>;
+               };
+
+               fan at 7 {
+                       reg = <0x03>;
+                       aspeed,fan-tach-ch = /bits/ 8 <0x07>;
+               };
+       };
 };

 &fmc {
diff --git a/arch/arm/boot/dts/aspeed-g4.dtsi b/arch/arm/boot/dts/aspeed-g4.dtsi
index a998a00a2728..9cc959fccfa0 100644
--- a/arch/arm/boot/dts/aspeed-g4.dtsi
+++ b/arch/arm/boot/dts/aspeed-g4.dtsi
@@ -36,6 +36,11 @@
         };

         clocks {
+               pwm_tacho_fixed_clk: fixedclk {
+                       compatible = "fixed-clock";
+                       #clock-cells = <0>;
+                       clock-frequency = <24000000>;
+               };
         };

         ahb {
--
2.13.1.611.g7e3b11ae1-goog

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ozlabs.org/pipermail/openbmc/attachments/20170629/36721f47/attachment-0001.html>