<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=koi8-r">
<meta name="Generator" content="Microsoft Exchange Server">
<!-- converted from text --><style><!-- .EmailQuote { margin-left: 1pt; padding-left: 4pt; border-left: #800000 2px solid; } --></style>
</head>
<body>
<meta content="text/html; charset=UTF-8">
<style type="text/css" style="">
<!--
p
{margin-top:0;
margin-bottom:0}
-->
</style>
<div dir="ltr">
<div id="x_divtagdefaultwrapper" dir="ltr" style="font-size:12pt; color:#000000; font-family:Calibri,Helvetica,sans-serif">
<p>Hi!</p>
<p><br>
</p>
<p>We want to add <span style="color:rgb(33,33,33); font-family:wf_segoe-ui_normal,"Segoe UI","Segoe WP",Tahoma,Arial,sans-serif,serif,EmojiFont; font-size:13.3333px">pwm_tacho for msn platform too.</span></p>
<p><span style="color:rgb(33,33,33); font-family:wf_segoe-ui_normal,"Segoe UI","Segoe WP",Tahoma,Arial,sans-serif,serif,EmojiFont; font-size:13.3333px">Is there some special reason why you add <span style="color:rgb(33,33,33); font-family:wf_segoe-ui_normal,"Segoe UI","Segoe WP",Tahoma,Arial,sans-serif,serif,EmojiFont; font-size:13.3333px">pwm_tacho:
pwm-tacho-controller@1e786000 to .dts not <span style="color:rgb(33,33,33); font-family:wf_segoe-ui_normal,"Segoe UI","Segoe WP",Tahoma,Arial,sans-serif,serif,EmojiFont; font-size:13.3333px">.dtsi file?</span></span></span></p>
<p><span style="color:rgb(33,33,33); font-family:wf_segoe-ui_normal,"Segoe UI","Segoe WP",Tahoma,Arial,sans-serif,serif,EmojiFont; font-size:13.3333px"><span style="color:rgb(33,33,33); font-family:wf_segoe-ui_normal,"Segoe UI","Segoe WP",Tahoma,Arial,sans-serif,serif,EmojiFont; font-size:13.3333px"><span style="color:rgb(33,33,33); font-family:wf_segoe-ui_normal,"Segoe UI","Segoe WP",Tahoma,Arial,sans-serif,serif,EmojiFont; font-size:13.3333px"><br>
</span></span></span></p>
<p><font color="#212121" face="wf_segoe-ui_normal, Segoe UI, Segoe WP, Tahoma, Arial, sans-serif, serif, EmojiFont"><span style="font-size:13.3333px">What about add this: <span style="color:rgb(33,33,33); font-family:wf_segoe-ui_normal,"Segoe UI","Segoe WP",Tahoma,Arial,sans-serif,serif,EmojiFont; font-size:13.3333px"></span></span></font></p>
<p><font color="#212121" face="wf_segoe-ui_normal, Segoe UI, Segoe WP, Tahoma, Arial, sans-serif, serif, EmojiFont"><span style="font-size:13.3333px"><span style="color:rgb(33,33,33); font-family:wf_segoe-ui_normal,"Segoe UI","Segoe WP",Tahoma,Arial,sans-serif,serif,EmojiFont; font-size:13.3333px">
pwm_tacho: pwm-tacho-controller@1e786000 {</span><br style="color:rgb(33,33,33); font-family:wf_segoe-ui_normal,"Segoe UI","Segoe WP",Tahoma,Arial,sans-serif,serif,EmojiFont; font-size:13.3333px">
<span style="color:rgb(33,33,33); font-family:wf_segoe-ui_normal,"Segoe UI","Segoe WP",Tahoma,Arial,sans-serif,serif,EmojiFont; font-size:13.3333px"> #address-cells = <1>;</span><br style="color:rgb(33,33,33); font-family:wf_segoe-ui_normal,"Segoe UI","Segoe WP",Tahoma,Arial,sans-serif,serif,EmojiFont; font-size:13.3333px">
<span style="color:rgb(33,33,33); font-family:wf_segoe-ui_normal,"Segoe UI","Segoe WP",Tahoma,Arial,sans-serif,serif,EmojiFont; font-size:13.3333px"> #size-cells = <1>;</span><br style="color:rgb(33,33,33); font-family:wf_segoe-ui_normal,"Segoe UI","Segoe WP",Tahoma,Arial,sans-serif,serif,EmojiFont; font-size:13.3333px">
<span style="color:rgb(33,33,33); font-family:wf_segoe-ui_normal,"Segoe UI","Segoe WP",Tahoma,Arial,sans-serif,serif,EmojiFont; font-size:13.3333px"> reg = <0x1e786000 0x1000>;</span><br style="color:rgb(33,33,33); font-family:wf_segoe-ui_normal,"Segoe UI","Segoe WP",Tahoma,Arial,sans-serif,serif,EmojiFont; font-size:13.3333px">
<span style="color:rgb(33,33,33); font-family:wf_segoe-ui_normal,"Segoe UI","Segoe WP",Tahoma,Arial,sans-serif,serif,EmojiFont; font-size:13.3333px"> compatible = "aspeed,ast2500-pwm-tacho";</span><br style="color:rgb(33,33,33); font-family:wf_segoe-ui_normal,"Segoe UI","Segoe WP",Tahoma,Arial,sans-serif,serif,EmojiFont; font-size:13.3333px">
<span style="color:rgb(33,33,33); font-family:wf_segoe-ui_normal,"Segoe UI","Segoe WP",Tahoma,Arial,sans-serif,serif,EmojiFont; font-size:13.3333px"> clocks = <&pwm_tacho_fixed_clk>;</span><br style="color:rgb(33,33,33); font-family:wf_segoe-ui_normal,"Segoe UI","Segoe WP",Tahoma,Arial,sans-serif,serif,EmojiFont; font-size:13.3333px">
<span style="color:rgb(33,33,33); font-family:wf_segoe-ui_normal,"Segoe UI","Segoe WP",Tahoma,Arial,sans-serif,serif,EmojiFont; font-size:13.3333px"> pinctrl-names = "default";</span><br>
</span></font></p>
<p><span style="color:rgb(33,33,33); font-family:wf_segoe-ui_normal,"Segoe UI","Segoe WP",Tahoma,Arial,sans-serif,serif,EmojiFont; font-size:13.3333px"><br>
</span></p>
<p><span style="color:rgb(33,33,33); font-family:wf_segoe-ui_normal,"Segoe UI","Segoe WP",Tahoma,Arial,sans-serif,serif,EmojiFont; font-size:13.3333px">to </span><span style="color:rgb(33,33,33); font-family:wf_segoe-ui_normal,"Segoe UI","Segoe WP",Tahoma,Arial,sans-serif,serif,EmojiFont; font-size:13.3333px">aspeed-g5.dtsi?</span><br>
</p>
<p><span style="color:rgb(33,33,33); font-family:wf_segoe-ui_normal,"Segoe UI","Segoe WP",Tahoma,Arial,sans-serif,serif,EmojiFont; font-size:13.3333px"><br>
</span></p>
<p>And specific like pinctrl and fan:</p>
<p><span style="color:rgb(33,33,33); font-family:wf_segoe-ui_normal,"Segoe UI","Segoe WP",Tahoma,Arial,sans-serif,serif,EmojiFont; font-size:13.3333px"> pinctrl-0 = <&pinctrl_pwm0_default &pinctrl_pwm1_default</span><br style="color:rgb(33,33,33); font-family:wf_segoe-ui_normal,"Segoe UI","Segoe WP",Tahoma,Arial,sans-serif,serif,EmojiFont; font-size:13.3333px">
<span style="color:rgb(33,33,33); font-family:wf_segoe-ui_normal,"Segoe UI","Segoe WP",Tahoma,Arial,sans-serif,serif,EmojiFont; font-size:13.3333px"> &pinctrl_pwm2_default &pinctrl_pwm3_default>;</span><br style="color:rgb(33,33,33); font-family:wf_segoe-ui_normal,"Segoe UI","Segoe WP",Tahoma,Arial,sans-serif,serif,EmojiFont; font-size:13.3333px">
<br style="color:rgb(33,33,33); font-family:wf_segoe-ui_normal,"Segoe UI","Segoe WP",Tahoma,Arial,sans-serif,serif,EmojiFont; font-size:13.3333px">
<span style="color:rgb(33,33,33); font-family:wf_segoe-ui_normal,"Segoe UI","Segoe WP",Tahoma,Arial,sans-serif,serif,EmojiFont; font-size:13.3333px"> fan@0 {</span><br style="color:rgb(33,33,33); font-family:wf_segoe-ui_normal,"Segoe UI","Segoe WP",Tahoma,Arial,sans-serif,serif,EmojiFont; font-size:13.3333px">
<span style="color:rgb(33,33,33); font-family:wf_segoe-ui_normal,"Segoe UI","Segoe WP",Tahoma,Arial,sans-serif,serif,EmojiFont; font-size:13.3333px"> reg = <0x00>;</span><br style="color:rgb(33,33,33); font-family:wf_segoe-ui_normal,"Segoe UI","Segoe WP",Tahoma,Arial,sans-serif,serif,EmojiFont; font-size:13.3333px">
<span style="color:rgb(33,33,33); font-family:wf_segoe-ui_normal,"Segoe UI","Segoe WP",Tahoma,Arial,sans-serif,serif,EmojiFont; font-size:13.3333px"> aspeed,fan-tach-ch = /bits/ 8 <0x00>;</span><br style="color:rgb(33,33,33); font-family:wf_segoe-ui_normal,"Segoe UI","Segoe WP",Tahoma,Arial,sans-serif,serif,EmojiFont; font-size:13.3333px">
<span style="color:rgb(33,33,33); font-family:wf_segoe-ui_normal,"Segoe UI","Segoe WP",Tahoma,Arial,sans-serif,serif,EmojiFont; font-size:13.3333px"> };</span><br>
</p>
<p><span style="color:rgb(33,33,33); font-family:wf_segoe-ui_normal,"Segoe UI","Segoe WP",Tahoma,Arial,sans-serif,serif,EmojiFont; font-size:13.3333px"><br>
</span></p>
<p><span style="color:rgb(33,33,33); font-family:wf_segoe-ui_normal,"Segoe UI","Segoe WP",Tahoma,Arial,sans-serif,serif,EmojiFont; font-size:13.3333px"><span style="font-family:Calibri,Helvetica,sans-serif,EmojiFont,"Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols; font-size:16px"> to
.dts file.</span><br>
</span></p>
<p><span style="color:rgb(33,33,33); font-family:wf_segoe-ui_normal,"Segoe UI","Segoe WP",Tahoma,Arial,sans-serif,serif,EmojiFont; font-size:13.3333px"><br>
</span></p>
<p><span style="color:rgb(33,33,33); font-family:wf_segoe-ui_normal,"Segoe UI","Segoe WP",Tahoma,Arial,sans-serif,serif,EmojiFont; font-size:13.3333px">Thanks.</span></p>
<p><span style="color:rgb(33,33,33); font-family:wf_segoe-ui_normal,"Segoe UI","Segoe WP",Tahoma,Arial,sans-serif,serif,EmojiFont; font-size:13.3333px">Best regards, Mykola Kostenok.</span></p>
</div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="x_divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>От:</b> openbmc <openbmc-bounces+c_mykolak=mellanox.com@lists.ozlabs.org> от имени Patrick Venture <venture@google.com><br>
<b>Отправлено:</b> 28 июня 2017 г. 17:23:04<br>
<b>Кому:</b> venture@google.com; joel@jms.id.au; openbmc@lists.ozlabs.org<br>
<b>Тема:</b> [PATCH linux dev-4.10 v3] ARM: dts: aspeed: quanta: Enable pwm fans</font>
<div> </div>
</div>
</div>
<font size="2"><span style="font-size:10pt;">
<div class="PlainText">Signed-off-by: Patrick Venture <venture@google.com><br>
---<br>
v3: lowercased hex address<br>
v2: Moved pwm_tacho_fixed_clk to clocks.<br>
---<br>
arch/arm/boot/dts/aspeed-bmc-quanta-q71l.dts | 51 ++++++++++++++++++++++++++++<br>
arch/arm/boot/dts/aspeed-g4.dtsi | 5 +++<br>
2 files changed, 56 insertions(+)<br>
<br>
diff --git a/arch/arm/boot/dts/aspeed-bmc-quanta-q71l.dts b/arch/arm/boot/dts/aspeed-bmc-quanta-q71l.dts<br>
index e609c53d58f5..3abc2954d26e 100644<br>
--- a/arch/arm/boot/dts/aspeed-bmc-quanta-q71l.dts<br>
+++ b/arch/arm/boot/dts/aspeed-bmc-quanta-q71l.dts<br>
@@ -46,6 +46,57 @@<br>
gpios = <&gpio ASPEED_GPIO(B, 3) GPIO_ACTIVE_LOW>;<br>
};<br>
};<br>
+<br>
+ pwm_tacho: pwm-tacho-controller@1e786000 {<br>
+ #address-cells = <1>;<br>
+ #size-cells = <1>;<br>
+ reg = <0x1e786000 0x1000>;<br>
+ compatible = "aspeed,ast2500-pwm-tacho";<br>
+ clocks = <&pwm_tacho_fixed_clk>;<br>
+ pinctrl-names = "default";<br>
+ pinctrl-0 = <&pinctrl_pwm0_default &pinctrl_pwm1_default<br>
+ &pinctrl_pwm2_default &pinctrl_pwm3_default>;<br>
+<br>
+ fan@0 {<br>
+ reg = <0x00>;<br>
+ aspeed,fan-tach-ch = /bits/ 8 <0x00>;<br>
+ };<br>
+<br>
+ fan@1 {<br>
+ reg = <0x01>;<br>
+ aspeed,fan-tach-ch = /bits/ 8 <0x01>;<br>
+ };<br>
+<br>
+ fan@2 {<br>
+ reg = <0x02>;<br>
+ aspeed,fan-tach-ch = /bits/ 8 <0x02>;<br>
+ };<br>
+<br>
+ fan@3 {<br>
+ reg = <0x03>;<br>
+ aspeed,fan-tach-ch = /bits/ 8 <0x03>;<br>
+ };<br>
+<br>
+ fan@4 {<br>
+ reg = <0x00>;<br>
+ aspeed,fan-tach-ch = /bits/ 8 <0x04>;<br>
+ };<br>
+<br>
+ fan@5 {<br>
+ reg = <0x01>;<br>
+ aspeed,fan-tach-ch = /bits/ 8 <0x05>;<br>
+ };<br>
+<br>
+ fan@6 {<br>
+ reg = <0x02>;<br>
+ aspeed,fan-tach-ch = /bits/ 8 <0x06>;<br>
+ };<br>
+<br>
+ fan@7 {<br>
+ reg = <0x03>;<br>
+ aspeed,fan-tach-ch = /bits/ 8 <0x07>;<br>
+ };<br>
+ };<br>
};<br>
<br>
&fmc {<br>
diff --git a/arch/arm/boot/dts/aspeed-g4.dtsi b/arch/arm/boot/dts/aspeed-g4.dtsi<br>
index a998a00a2728..9cc959fccfa0 100644<br>
--- a/arch/arm/boot/dts/aspeed-g4.dtsi<br>
+++ b/arch/arm/boot/dts/aspeed-g4.dtsi<br>
@@ -36,6 +36,11 @@<br>
};<br>
<br>
clocks {<br>
+ pwm_tacho_fixed_clk: fixedclk {<br>
+ compatible = "fixed-clock";<br>
+ #clock-cells = <0>;<br>
+ clock-frequency = <24000000>;<br>
+ };<br>
};<br>
<br>
ahb {<br>
-- <br>
2.13.1.611.g7e3b11ae1-goog<br>
<br>
</div>
</span></font>
</body>
</html>