[PATCH linux dev-4.10] ARM: dts: aspeed: quanta: Enable pwm fans

Patrick Venture venture at google.com
Tue Jun 27 02:07:11 AEST 2017


If you're referring strictly to the clock, maybe I should put it under:

https://github.com/openbmc/linux/blob/dev-4.10/arch/arm/boot/dts/aspeed-g4.dtsi#L38

Which I didn't notice before :)

Patrick

On Mon, Jun 26, 2017 at 12:18 AM, Joel Stanley <joel at jms.id.au> wrote:

> On Fri, Jun 23, 2017 at 10:54 AM, Patrick Venture <venture at google.com>
> wrote:
> > Signed-off-by: Patrick Venture <venture at google.com>
> > ---
> >  arch/arm/boot/dts/aspeed-bmc-quanta-q71l.dts | 51
> ++++++++++++++++++++++++++++
> >  arch/arm/boot/dts/aspeed-g4.dtsi             |  6 ++++
> >  2 files changed, 57 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/aspeed-bmc-quanta-q71l.dts
> b/arch/arm/boot/dts/aspeed-bmc-quanta-q71l.dts
> > index e609c53d58f5..3abc2954d26e 100644
> > --- a/arch/arm/boot/dts/aspeed-bmc-quanta-q71l.dts
> > +++ b/arch/arm/boot/dts/aspeed-bmc-quanta-q71l.dts
> > @@ -46,6 +46,57 @@
> >                         gpios = <&gpio ASPEED_GPIO(B, 3)
> GPIO_ACTIVE_LOW>;
> >                 };
> >         };
> > +
> > +       pwm_tacho: pwm-tacho-controller at 1e786000 {
> > +               #address-cells = <1>;
> > +               #size-cells = <1>;
> > +               reg = <0x1E786000 0x1000>;
> > +               compatible = "aspeed,ast2500-pwm-tacho";
> > +               clocks = <&pwm_tacho_fixed_clk>;
> > +               pinctrl-names = "default";
> > +               pinctrl-0 = <&pinctrl_pwm0_default &pinctrl_pwm1_default
> > +                       &pinctrl_pwm2_default &pinctrl_pwm3_default>;
> > +
> > +               fan at 0 {
> > +                       reg = <0x00>;
> > +                       aspeed,fan-tach-ch = /bits/ 8 <0x00>;
> > +               };
> > +
> > +               fan at 1 {
> > +                       reg = <0x01>;
> > +                       aspeed,fan-tach-ch = /bits/ 8 <0x01>;
> > +               };
> > +
> > +               fan at 2 {
> > +                       reg = <0x02>;
> > +                       aspeed,fan-tach-ch = /bits/ 8 <0x02>;
> > +               };
> > +
> > +               fan at 3 {
> > +                       reg = <0x03>;
> > +                       aspeed,fan-tach-ch = /bits/ 8 <0x03>;
> > +               };
> > +
> > +               fan at 4 {
> > +                       reg = <0x00>;
> > +                       aspeed,fan-tach-ch = /bits/ 8 <0x04>;
> > +               };
> > +
> > +               fan at 5 {
> > +                       reg = <0x01>;
> > +                       aspeed,fan-tach-ch = /bits/ 8 <0x05>;
> > +               };
> > +
> > +               fan at 6 {
> > +                       reg = <0x02>;
> > +                       aspeed,fan-tach-ch = /bits/ 8 <0x06>;
> > +               };
> > +
> > +               fan at 7 {
> > +                       reg = <0x03>;
> > +                       aspeed,fan-tach-ch = /bits/ 8 <0x07>;
> > +               };
> > +       };
> >  };
> >
> >  &fmc {
> > diff --git a/arch/arm/boot/dts/aspeed-g4.dtsi
> b/arch/arm/boot/dts/aspeed-g4.dtsi
> > index a998a00a2728..c93b0460cada 100644
> > --- a/arch/arm/boot/dts/aspeed-g4.dtsi
> > +++ b/arch/arm/boot/dts/aspeed-g4.dtsi
> > @@ -184,6 +184,12 @@
> >                                         reg = <0x2c>;
> >                                 };
> >
> > +                               pwm_tacho_fixed_clk: fixedclk {
> > +                                       compatible = "fixed-clock";
> > +                                       #clock-cells = <0>;
> > +                                       clock-frequency = <24000000>;
> > +                               };
>
> This is a bit strange. I don't think it should live at this spot in
> the device tree.
>
>
> > +
> >                                 hwrng at 1e6e2078 {
> >                                         compatible = "timeriomem_rng";
> >                                         reg = <0x1e6e2078 0x4>;
> > --
> > 2.13.1.611.g7e3b11ae1-goog
> >
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ozlabs.org/pipermail/openbmc/attachments/20170626/9fd34bfa/attachment-0001.html>


More information about the openbmc mailing list