<div dir="ltr">If you're referring strictly to the clock, maybe I should put it under:<div><br></div><div><a href="https://github.com/openbmc/linux/blob/dev-4.10/arch/arm/boot/dts/aspeed-g4.dtsi#L38">https://github.com/openbmc/linux/blob/dev-4.10/arch/arm/boot/dts/aspeed-g4.dtsi#L38</a><br></div><div><br></div><div>Which I didn't notice before :)</div><div><br></div><div>Patrick</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Jun 26, 2017 at 12:18 AM, Joel Stanley <span dir="ltr"><<a href="mailto:joel@jms.id.au" target="_blank">joel@jms.id.au</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">On Fri, Jun 23, 2017 at 10:54 AM, Patrick Venture <<a href="mailto:venture@google.com">venture@google.com</a>> wrote:<br>
> Signed-off-by: Patrick Venture <<a href="mailto:venture@google.com">venture@google.com</a>><br>
> ---<br>
>  arch/arm/boot/dts/aspeed-bmc-<wbr>quanta-q71l.dts | 51 ++++++++++++++++++++++++++++<br>
>  arch/arm/boot/dts/aspeed-g4.<wbr>dtsi             |  6 ++++<br>
>  2 files changed, 57 insertions(+)<br>
><br>
> diff --git a/arch/arm/boot/dts/aspeed-<wbr>bmc-quanta-q71l.dts b/arch/arm/boot/dts/aspeed-<wbr>bmc-quanta-q71l.dts<br>
> index e609c53d58f5..3abc2954d26e 100644<br>
> --- a/arch/arm/boot/dts/aspeed-<wbr>bmc-quanta-q71l.dts<br>
> +++ b/arch/arm/boot/dts/aspeed-<wbr>bmc-quanta-q71l.dts<br>
> @@ -46,6 +46,57 @@<br>
>                         gpios = <&gpio ASPEED_GPIO(B, 3) GPIO_ACTIVE_LOW>;<br>
>                 };<br>
>         };<br>
> +<br>
> +       pwm_tacho: pwm-tacho-controller@1e786000 {<br>
> +               #address-cells = <1>;<br>
> +               #size-cells = <1>;<br>
> +               reg = <0x1E786000 0x1000>;<br>
> +               compatible = "aspeed,ast2500-pwm-tacho";<br>
> +               clocks = <&pwm_tacho_fixed_clk>;<br>
> +               pinctrl-names = "default";<br>
> +               pinctrl-0 = <&pinctrl_pwm0_default &pinctrl_pwm1_default<br>
> +                       &pinctrl_pwm2_default &pinctrl_pwm3_default>;<br>
> +<br>
> +               fan@0 {<br>
> +                       reg = <0x00>;<br>
> +                       aspeed,fan-tach-ch = /bits/ 8 <0x00>;<br>
> +               };<br>
> +<br>
> +               fan@1 {<br>
> +                       reg = <0x01>;<br>
> +                       aspeed,fan-tach-ch = /bits/ 8 <0x01>;<br>
> +               };<br>
> +<br>
> +               fan@2 {<br>
> +                       reg = <0x02>;<br>
> +                       aspeed,fan-tach-ch = /bits/ 8 <0x02>;<br>
> +               };<br>
> +<br>
> +               fan@3 {<br>
> +                       reg = <0x03>;<br>
> +                       aspeed,fan-tach-ch = /bits/ 8 <0x03>;<br>
> +               };<br>
> +<br>
> +               fan@4 {<br>
> +                       reg = <0x00>;<br>
> +                       aspeed,fan-tach-ch = /bits/ 8 <0x04>;<br>
> +               };<br>
> +<br>
> +               fan@5 {<br>
> +                       reg = <0x01>;<br>
> +                       aspeed,fan-tach-ch = /bits/ 8 <0x05>;<br>
> +               };<br>
> +<br>
> +               fan@6 {<br>
> +                       reg = <0x02>;<br>
> +                       aspeed,fan-tach-ch = /bits/ 8 <0x06>;<br>
> +               };<br>
> +<br>
> +               fan@7 {<br>
> +                       reg = <0x03>;<br>
> +                       aspeed,fan-tach-ch = /bits/ 8 <0x07>;<br>
> +               };<br>
> +       };<br>
>  };<br>
><br>
>  &fmc {<br>
> diff --git a/arch/arm/boot/dts/aspeed-g4.<wbr>dtsi b/arch/arm/boot/dts/aspeed-g4.<wbr>dtsi<br>
> index a998a00a2728..c93b0460cada 100644<br>
> --- a/arch/arm/boot/dts/aspeed-g4.<wbr>dtsi<br>
> +++ b/arch/arm/boot/dts/aspeed-g4.<wbr>dtsi<br>
> @@ -184,6 +184,12 @@<br>
>                                         reg = <0x2c>;<br>
>                                 };<br>
><br>
> +                               pwm_tacho_fixed_clk: fixedclk {<br>
> +                                       compatible = "fixed-clock";<br>
> +                                       #clock-cells = <0>;<br>
> +                                       clock-frequency = <24000000>;<br>
> +                               };<br>
<br>
</div></div>This is a bit strange. I don't think it should live at this spot in<br>
the device tree.<br>
<div class="HOEnZb"><div class="h5"><br>
<br>
> +<br>
>                                 hwrng@1e6e2078 {<br>
>                                         compatible = "timeriomem_rng";<br>
>                                         reg = <0x1e6e2078 0x4>;<br>
> --<br>
> 2.13.1.611.g7e3b11ae1-goog<br>
><br>
</div></div></blockquote></div><br></div>