[PATCH v2 4/5] drivers/mailbox: Add aspeed ast2400/ast2500 mbox driver

Benjamin Herrenschmidt benh at au1.ibm.com
Mon Jan 9 08:45:06 AEDT 2017


On Tue, 2017-01-03 at 11:54 +1030, Andrew Jeffery wrote:
> > > I think we should rename the IOCTL as what we do below doesn't
> > > necessarily raise an interrupt.
> > > 
>> > Agreed, taking unput :). ASPEED_MBOX_IOCTL_WRITE_BYTE ?
> 
> That suggestion works for me.

If we are going to do that, maybe we should make this a write()
at a specific lpos...

Otherwise call it something like SET_ATTN or SET_FLAGS ...

Cheers,
Ben.



More information about the openbmc mailing list