[PATCH v2 4/5] drivers/mailbox: Add aspeed ast2400/ast2500 mbox driver

Andrew Jeffery andrew at aj.id.au
Mon Jan 9 10:54:24 AEDT 2017


On Sun, 2017-01-08 at 15:44 -0600, Benjamin Herrenschmidt wrote:
> On Tue, 2017-01-03 at 11:54 +1030, Andrew Jeffery wrote:
> > 
> > regmap_update_bits() will just write back what it read for the
> > untouched bits, which should be 0 in accordance with the datasheet.
> > It's not really a change in behaviour as we will still be writing to
> > reserved bits, but I think it makes the intent clear.
> 
> It wastes cycles though...

True. 

That sways me towards leaving it as a regmap_write().

Andrew
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: This is a digitally signed message part
URL: <http://lists.ozlabs.org/pipermail/openbmc/attachments/20170109/6b5388f1/attachment.sig>


More information about the openbmc mailing list