[PATCH] Fix i2c-tools SRCURI syntax

[Rick Altherr]

Shall I resend this patch as a pull request?

On Wed, May 25, 2016 at 6:24 PM, Andrew Jeffery <andrew at aj.id.au> wrote:

> Hi Rick,
>
> Thanks for the patch. I've reproduced the warning* and tested the fix.
> As an aside, the commit message introducing the .bbappend was pretty
> terse, I assume the reason for switching the SRC_URI is that
> {www,dl}.lm-sensors.org seem to be unreachable.
>
> Separately, the means to contribute to OpenBMC is a bit fragmented at
> the moment, and there are ongoing discussions about how to manage it.
> As it stands for the openbmc/openbmc repository, pull-requests are the
> preferred approach. More generally, for projects that are OpenBMC-
> specific pull-requests are preferred**, but for contributions to our
> forks of other projects the upstream workflow is preferred. So for u-
> boot, the kernel and qemu, sending patches to the list is the way to
> go.
>
> * The warning was:
> WARNING: Failed to fetch URL
> http://downloads.yoctoproject.org/mirror/sources/i2c-tools-3.1.2.tar.bz2http://dl.lm-sensors.org/i2c-tools/releases/i2c-tools-3.1.2.tar.bz2,
> attempting MIRRORS if available
>
> ** Though the word is the OpenBMC repos will be using Gerrit shortly
>
> On Wed, 2016-05-25 at 17:37 -0700, Rick Altherr wrote:
> > Override syntax (FOO_append, FOO_prepend) doesn't insert spaces to
> > separate the append from the original value.  This caused the two URIs
> > to be incorrectly merged into one and caused a download failure.  It
> > happens that the fallback in that case is to use the Yocto mirror so it
> > kept working other than emitting a warning.  Using =+ prepend syntax
> > correctly adds the separating space.
> >
> > Change-Id: I36f48cb53aa29ea9a4bde738c975784f6ce24250
> > Signed-off-by: Rick Altherr <raltherr at google.com>
>
> Reviewed-by: Andrew Jeffery <andrew at aj.id.au>
>
> Cheers,
>
> Andrew
>
> > ---
> >  meta-phosphor/common/recipes-devtools/i2c-tools/i2c-tools_%.bbappend |
> 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git
> a/meta-phosphor/common/recipes-devtools/i2c-tools/i2c-tools_%.bbappend
> b/meta-phosphor/common/recipes-devtools/i2c-tools/i2c-tools_%.bbappend
> > index bdbdc67..599394d 100644
> > ---
> a/meta-phosphor/common/recipes-devtools/i2c-tools/i2c-tools_%.bbappend
> > +++
> b/meta-phosphor/common/recipes-devtools/i2c-tools/i2c-tools_%.bbappend
> > @@ -1,4 +1,5 @@
> > +# Prefer the Yocto mirror over the direct lm-sensors download.
> >  SRC_URI_remove = "
> http://dl.lm-sensors.org/i2c-tools/releases/${BP}.tar.bz2"
> > -SRC_URI_prepend = "
> http://downloads.yoctoproject.org/mirror/sources/${BP}.tar.bz2"
> > +SRC_URI =+ "
> http://downloads.yoctoproject.org/mirror/sources/${BP}.tar.bz2"
> >
> >  RDEPENDS_${PN}_remove = "${PN}-misc"
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ozlabs.org/pipermail/openbmc/attachments/20160525/f4a27a57/attachment-0001.html>