<div dir="ltr">Shall I resend this patch as a pull request?</div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, May 25, 2016 at 6:24 PM, Andrew Jeffery <span dir="ltr"><<a href="mailto:andrew@aj.id.au" target="_blank">andrew@aj.id.au</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Rick,<br>
<br>
Thanks for the patch. I've reproduced the warning* and tested the fix.<br>
As an aside, the commit message introducing the .bbappend was pretty<br>
terse, I assume the reason for switching the SRC_URI is that<br>
{www,dl}.<a href="http://lm-sensors.org" rel="noreferrer" target="_blank">lm-sensors.org</a> seem to be unreachable.<br>
<br>
Separately, the means to contribute to OpenBMC is a bit fragmented at<br>
the moment, and there are ongoing discussions about how to manage it.<br>
As it stands for the openbmc/openbmc repository, pull-requests are the<br>
preferred approach. More generally, for projects that are OpenBMC-<br>
specific pull-requests are preferred**, but for contributions to our<br>
forks of other projects the upstream workflow is preferred. So for u-<br>
boot, the kernel and qemu, sending patches to the list is the way to<br>
go.<br>
<br>
* The warning was:<br>
WARNING: Failed to fetch URL <a href="http://downloads.yoctoproject.org/mirror/sources/i2c-tools-3.1.2.tar.bz2http://dl.lm-sensors.org/i2c-tools/releases/i2c-tools-3.1.2.tar.bz2" rel="noreferrer" target="_blank">http://downloads.yoctoproject.org/mirror/sources/i2c-tools-3.1.2.tar.bz2http://dl.lm-sensors.org/i2c-tools/releases/i2c-tools-3.1.2.tar.bz2</a>, attempting MIRRORS if available<br>
<br>
** Though the word is the OpenBMC repos will be using Gerrit shortly<br>
<span class=""><br>
On Wed, 2016-05-25 at 17:37 -0700, Rick Altherr wrote:<br>
> Override syntax (FOO_append, FOO_prepend) doesn't insert spaces to<br>
> separate the append from the original value.  This caused the two URIs<br>
> to be incorrectly merged into one and caused a download failure.  It<br>
> happens that the fallback in that case is to use the Yocto mirror so it<br>
> kept working other than emitting a warning.  Using =+ prepend syntax<br>
> correctly adds the separating space.<br>
><br>
> Change-Id: I36f48cb53aa29ea9a4bde738c975784f6ce24250<br>
> Signed-off-by: Rick Altherr <<a href="mailto:raltherr@google.com">raltherr@google.com</a>><br>
<br>
</span>Reviewed-by: Andrew Jeffery <<a href="mailto:andrew@aj.id.au">andrew@aj.id.au</a>><br>
<br>
Cheers,<br>
<br>
Andrew<br>
<div class="HOEnZb"><div class="h5"><br>
> ---<br>
>  meta-phosphor/common/recipes-devtools/i2c-tools/i2c-tools_%.bbappend | 3 ++-<br>
>  1 file changed, 2 insertions(+), 1 deletion(-)<br>
><br>
> diff --git a/meta-phosphor/common/recipes-devtools/i2c-tools/i2c-tools_%.bbappend b/meta-phosphor/common/recipes-devtools/i2c-tools/i2c-tools_%.bbappend<br>
> index bdbdc67..599394d 100644<br>
> --- a/meta-phosphor/common/recipes-devtools/i2c-tools/i2c-tools_%.bbappend<br>
> +++ b/meta-phosphor/common/recipes-devtools/i2c-tools/i2c-tools_%.bbappend<br>
> @@ -1,4 +1,5 @@<br>
> +# Prefer the Yocto mirror over the direct lm-sensors download.<br>
>  SRC_URI_remove = "<a href="http://dl.lm-sensors.org/i2c-tools/releases/${BP}.tar.bz2" rel="noreferrer" target="_blank">http://dl.lm-sensors.org/i2c-tools/releases/${BP}.tar.bz2</a>"<br>
> -SRC_URI_prepend = "<a href="http://downloads.yoctoproject.org/mirror/sources/${BP}.tar.bz2" rel="noreferrer" target="_blank">http://downloads.yoctoproject.org/mirror/sources/${BP}.tar.bz2</a>"<br>
> +SRC_URI =+ "<a href="http://downloads.yoctoproject.org/mirror/sources/${BP}.tar.bz2" rel="noreferrer" target="_blank">http://downloads.yoctoproject.org/mirror/sources/${BP}.tar.bz2</a>"<br>
>  <br>
>  RDEPENDS_${PN}_remove = "${PN}-misc"</div></div></blockquote></div><br></div>