[PATCH phosphor-host-ipmid] Returning correct value from handle_ipmid_command in ipmid.C

[Vishwanatha Subbanna]

hello Nan Li,

I wonder if there is a github pull request for this ?

Thanks

-------------------------------------------------------------------------------------

Thanks and Regards,
Vishwanath.
Advisory Software Engineer,
Power Firmware Development,
Systems &Technology Lab,
MG2-6F-255 , Manyata Embassy Business Park,
Bangalore , KA , 560045
Ph: +91-80-46678255
E-mail: vishwanath at in.ibm.com
----------------------------------------------------------------------------------



From:	OpenBMC Patches <openbmc-patches at stwcx.xyz>
To:	openbmc at lists.ozlabs.org
Cc:	Nan Li <bjlinan at cn.ibm.com>
Date:	24/05/2016 02:11 pm
Subject:	[PATCH phosphor-host-ipmid] Returning correct value from
            handle_ipmid_command in ipmid.C
Sent by:	"openbmc" <openbmc-bounces
            +vishwanath=in.ibm.com at lists.ozlabs.org>



From: Nan Li <bjlinan at cn.ibm.com>

Instead of -1, we return 0xFF(Unspecified error) to the bus.

Signed-off-by: Nan Li <bjlinan at cn.ibm.com>
---
 ipmid.C | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/ipmid.C b/ipmid.C
index 728ba0b..9009cd6 100644
--- a/ipmid.C
+++ b/ipmid.C
@@ -267,6 +267,10 @@ static int handle_ipmi_command(sd_bus_message *m, void
*user_data, sd_bus_error
     if(r != 0)
     {
         fprintf(stderr,"ERROR:[0x%X] handling NetFn:[0x%X],
Cmd:[0x%X]\n",r, netfn, cmd);
+
+        if(r == -1) {
+           response[0] = IPMI_CC_UNSPECIFIED_ERROR;
+        }
     }

     fprintf(ipmiio, "IPMI Response:\n");
--
2.8.3


_______________________________________________
openbmc mailing list
openbmc at lists.ozlabs.org
https://lists.ozlabs.org/listinfo/openbmc


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ozlabs.org/pipermail/openbmc/attachments/20160524/35e30196/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: graycol.gif
Type: image/gif
Size: 105 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/openbmc/attachments/20160524/35e30196/attachment.gif>