<html><body><p>hello Nan Li,<br><br>I wonder if there is a github pull request for this ?<br><br>Thanks<br><br>-------------------------------------------------------------------------------------<br>Thanks and Regards,<br>Vishwanath.<br>Advisory Software Engineer,<br>Power Firmware Development, <br>Systems &Technology Lab,<br>MG2-6F-255 , Manyata Embassy Business Park, <br>Bangalore , KA , 560045<br>Ph: +91-80-46678255<br>E-mail: vishwanath@in.ibm.com<br>----------------------------------------------------------------------------------<br><br><img width="16" height="16" src="cid:1__=EABBF52EDFD4FB468f9e8a93df938690918cEAB@" border="0" alt="Inactive hide details for OpenBMC Patches ---24/05/2016 02:11:43 pm---From: Nan Li <bjlinan@cn.ibm.com> Instead of -1, we retur"><font color="#424282">OpenBMC Patches ---24/05/2016 02:11:43 pm---From: Nan Li <bjlinan@cn.ibm.com> Instead of -1, we return 0xFF(Unspecified error) to the bus.</font><br><br><font size="2" color="#5F5F5F">From: </font><font size="2">OpenBMC Patches <openbmc-patches@stwcx.xyz></font><br><font size="2" color="#5F5F5F">To: </font><font size="2">openbmc@lists.ozlabs.org</font><br><font size="2" color="#5F5F5F">Cc: </font><font size="2">Nan Li <bjlinan@cn.ibm.com></font><br><font size="2" color="#5F5F5F">Date: </font><font size="2">24/05/2016 02:11 pm</font><br><font size="2" color="#5F5F5F">Subject: </font><font size="2">[PATCH phosphor-host-ipmid] Returning correct value from handle_ipmid_command in ipmid.C</font><br><font size="2" color="#5F5F5F">Sent by: </font><font size="2">"openbmc" <openbmc-bounces+vishwanath=in.ibm.com@lists.ozlabs.org></font><br><hr width="100%" size="2" align="left" noshade style="color:#8091A5; "><br><br><br><tt>From: Nan Li <bjlinan@cn.ibm.com><br><br>Instead of -1, we return 0xFF(Unspecified error) to the bus.<br><br>Signed-off-by: Nan Li <bjlinan@cn.ibm.com><br>---<br> ipmid.C | 4 ++++<br> 1 file changed, 4 insertions(+)<br><br>diff --git a/ipmid.C b/ipmid.C<br>index 728ba0b..9009cd6 100644<br>--- a/ipmid.C<br>+++ b/ipmid.C<br>@@ -267,6 +267,10 @@ static int handle_ipmi_command(sd_bus_message *m, void *user_data, sd_bus_error<br> if(r != 0)<br> {<br> fprintf(stderr,"ERROR:[0x%X] handling NetFn:[0x%X], Cmd:[0x%X]\n",r, netfn, cmd);<br>+<br>+ if(r == -1) {<br>+ response[0] = IPMI_CC_UNSPECIFIED_ERROR;<br>+ }<br> }<br> <br> fprintf(ipmiio, "IPMI Response:\n");<br>-- <br>2.8.3<br><br><br>_______________________________________________<br>openbmc mailing list<br>openbmc@lists.ozlabs.org<br></tt><tt><a href="https://lists.ozlabs.org/listinfo/openbmc">https://lists.ozlabs.org/listinfo/openbmc</a></tt><tt><br></tt><br><br><BR>
</body></html>