[PATCH 4/6] arm/dts: Set I2C_TEN_BIT_ADDRESS in Firestone BMC board i2c addresses

Benjamin Herrenschmidt benh at au1.ibm.com
Fri May 6 10:53:45 AEST 2016


On Thu, 2016-05-05 at 22:51 +0930, Joel Stanley wrote:
> On Thu, May 5, 2016 at 10:57 AM, Cyril Bur <cyrilbur at gmail.com>
> wrote:
> 
> Did you work out why we needed this, and why it fixes things?
> 
> Should we be doing it for all the device trees?

That's weird indeed... Is there a 10-bit device on that bus ? Otherwise
we shouldn't emit 10-bit addresses. In general, 10-bit addresses stuff
doesn't work, in my experience at least. We might be papering over some
other problem...

> > 
> > Signed-off-by: Cyril Bur <cyrilbur at gmail.com>
> > ---
> >  arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts | 12 ++++++------
> >  1 file changed, 6 insertions(+), 6 deletions(-)
> > 
> > diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts
> > b/arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts
> > index 2b988e7..379b561 100644
> > --- a/arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts
> > +++ b/arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts
> > @@ -75,7 +75,7 @@
> >                                 i2c5: i2c-bus at 180 {
> >                                         tmp423 at 98 {
> >                                                 compatible =
> > "ti,tmp423";
> > -                                               reg = <0x98>;
> > +                                               reg = <0x80000098>;
> >                                         };
> >                                 };
> >                                 i2c6: i2c-bus at 1c0 {
> > @@ -98,27 +98,27 @@
> >                                         status = "okay";
> >                                         leds at c0 {
> >                                                 compatible =
> > "pca,pca9552led";
> > -                                               reg = <0xc0>;
> > +                                               reg = <0x800000c0>;
> >                                                 // led9 -
> > led_fault_n
> >                                                 // led10 -
> > pwr_led_n
> >                                                 // led11 -
> > rear_id_led_n
> >                                         };
> >                                         rtc at d0 {
> >                                                 compatible =
> > "dallas,ds3231";
> > -                                               reg = <0xd0>;
> > +                                               reg = <0x800000d0>;
> >                                         };
> >                                         si5338a at e2 {
> >                                                 // SiLabs clock
> > generator
> > -                                               reg =<0xe2>;
> > +                                               reg =<0x800000e2>;
> >                                         };
> > 
> >                                         idt at d6 {
> >                                                 // IDT 9DBV0641
> > clock buffer
> > -                                               reg = <0xd6>;
> > +                                               reg = <0x800000d6>;
> >                                         };
> > 
> >                                         tpm at a3 {
> > -                                               reg = <0xa3>;
> > +                                               reg = <0x800000a3>;
> >                                         };
> >                                 };
> >                                 i2c12: i2c-bus at 440 {
> > --
> > 2.8.2
> > 
> > _______________________________________________
> > openbmc mailing list
> > openbmc at lists.ozlabs.org
> > https://lists.ozlabs.org/listinfo/openbmc
> _______________________________________________
> openbmc mailing list
> openbmc at lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/openbmc



More information about the openbmc mailing list