[RFC/PATCH 2/12] powerpc: Remove #ifdef ISERIES from __raw_* accessors in io.h

[will schmidt]

David Gibson wrote:
> On Tue, Jan 17, 2006 at 11:14:06AM +0100, Christoph Hellwig wrote:
> 
>>>+static inline unsigned char __raw_readb(const volatile void __iomem *addr)
>>>+{
>>>+	if (firmware_has_feature(FW_FEATURE_ISERIES))
>>>+		BUG();	/* raw accessors aren't supported on iSeries */
>>>+
>>>+	return *(volatile unsigned char __force *)addr;
>>>+}
>>
>>Actually ~his is still wrong.  You must support these as they are part
>>of the Linux driver API.  Even if that means endianess swap the value
>>back and still doing all the barriers the full versions do.
> 
> 
> If no-one's hit this on legacy iSeries so far, it's staggeringly
> unlikely they ever will.  These machines have no real IO, it's all
> virtual.
> 

Confirming what both of you said...
The defines were originally added so that folks could build both iseries
and pseries kernels against a common list of modules. (IIRC, This was by request
from one of the distros).

The defines only exist to avoid the build errors.

> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> Linuxppc64-dev mailing list
> Linuxppc64-dev at ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc64-dev