[RFC/PATCH 2/12] powerpc: Remove #ifdef ISERIES from __raw_* accessors in io.h

[Stephen Rothwell]

On Tue, 17 Jan 2006 11:14:06 +0100 Christoph Hellwig <hch at lst.de> wrote:
>
> > +static inline unsigned char __raw_readb(const volatile void __iomem *addr)
> > +{
> > +	if (firmware_has_feature(FW_FEATURE_ISERIES))
> > +		BUG();	/* raw accessors aren't supported on iSeries */
> > +
> > +	return *(volatile unsigned char __force *)addr;
> > +}
> 
> Actually þhis is still wrong.  You must support these as they are part
> of the Linux driver API.  Even if that means endianess swap the value
> back and still doing all the barriers the full versions do.

These have never been supported on iSeries so the drivers for the (fairly
tightly controlled) set of hardware that will run on iSeries obviously don't
need them.

iSeries is a legacy platform ...
-- 
Cheers,
Stephen Rothwell                    sfr at canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://ozlabs.org/pipermail/linuxppc64-dev/attachments/20060117/ac46ed0a/attachment.pgp