[RFC/PATCH 2/12] powerpc: Remove #ifdef ISERIES from __raw_* accessors in io.h
David Gibson
david at gibson.dropbear.id.au
Tue Jan 17 21:32:47 EST 2006
On Tue, Jan 17, 2006 at 11:14:06AM +0100, Christoph Hellwig wrote:
> > +static inline unsigned char __raw_readb(const volatile void __iomem *addr)
> > +{
> > + if (firmware_has_feature(FW_FEATURE_ISERIES))
> > + BUG(); /* raw accessors aren't supported on iSeries */
> > +
> > + return *(volatile unsigned char __force *)addr;
> > +}
>
> Actually þhis is still wrong. You must support these as they are part
> of the Linux driver API. Even if that means endianess swap the value
> back and still doing all the barriers the full versions do.
If no-one's hit this on legacy iSeries so far, it's staggeringly
unlikely they ever will. These machines have no real IO, it's all
virtual.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
More information about the Linuxppc64-dev
mailing list