[RFC/PATCH 2/12] powerpc: Remove #ifdef ISERIES from __raw_* accessors in io.h

Christoph Hellwig hch at lst.de
Tue Jan 17 21:14:06 EST 2006


> +static inline unsigned char __raw_readb(const volatile void __iomem *addr)
> +{
> +	if (firmware_has_feature(FW_FEATURE_ISERIES))
> +		BUG();	/* raw accessors aren't supported on iSeries */
> +
> +	return *(volatile unsigned char __force *)addr;
> +}

Actually þhis is still wrong.  You must support these as they are part
of the Linux driver API.  Even if that means endianess swap the value
back and still doing all the barriers the full versions do.




More information about the Linuxppc64-dev mailing list