Booting Imac G5 : Wrong patch

Benjamin Herrenschmidt benh at
Mon Nov 15 09:15:29 EST 2004

On Sun, 2004-11-14 at 16:34 +0100, J. Mayer wrote:

> The previous patch I sent was buggy:
> I added the shasta controler in the pmac_ide driver but made a mistake:
> I missed an else statement so the controler was still recognized as an
> Ohare one.
> It's now well recognized (but uses k2 UDMA 100 timings) and runs in
> UDMA2 mode instead of MDMA2.
> The corrected full patch is attached.

I see that you added U/DMA 133 to the capabilities of the ide-pmac
driver, but didn't update the timing tables... Have you checked those ?

Also, it would be nice if you could avoid making lines go beyond 80
columns ;)


More information about the Linuxppc64-dev mailing list