Booting Imac G5 : Wrong patch

J. Mayer l_indien at
Mon Nov 15 09:37:48 EST 2004

On Sun, 2004-11-14 at 23:15, Benjamin Herrenschmidt wrote:
> On Sun, 2004-11-14 at 16:34 +0100, J. Mayer wrote:
> > The previous patch I sent was buggy:
> > I added the shasta controler in the pmac_ide driver but made a mistake:
> > I missed an else statement so the controler was still recognized as an
> > Ohare one.
> > It's now well recognized (but uses k2 UDMA 100 timings) and runs in
> > UDMA2 mode instead of MDMA2.
> > 
> > The corrected full patch is attached.
> I see that you added U/DMA 133 to the capabilities of the ide-pmac
> driver, but didn't update the timing tables... Have you checked those ?

You're right, I should have #if zeroed those two lines, 'cause I got no
ideas of the needed timings...
My first goal is to get the controller well recognized (ie not as an
Ohare !). 

> Also, it would be nice if you could avoid making lines go beyond 80
> columns ;)

You're right. I hate this too, in fact !
Should never cut & paste ;-)

J. Mayer <l_indien at>
Never organized

More information about the Linuxppc64-dev mailing list