[PATCH] i2c-mpc: don't disable I2C module on stop condition.

Guennadi Liakhovetski g.liakhovetski at gmx.de
Thu Aug 9 04:33:52 EST 2007


On Wed, 8 Aug 2007, Jean Delvare wrote:

> Hi Domen,
> 
> On Tue, 24 Jul 2007 07:14:31 +0200, Domen Puncer wrote:
> > Disabling module on stop doesn't work on some CPUs (ie. mpc8241,
> > as reported by Guennadi Liakhovetski), so remove that.
> > 
> > Disable I2C module on errors/interrupts to prevent it from
> > locking up on mpc5200b.
> > 
> > 
> > Signed-off-by: Domen Puncer <domen.puncer at telargo.com>
> > ---
> > Hi!
> > 
> > So I fixed i2c on one board, and broke it on another :-(
> > This patch works on both Guennadi's and mine (hey, it might break
> > a third one!).
> > Jean, can you please push this, if there are no objections
> > and "doesn't work for me" reports.
> 
> Queued for 2.6.23-rc3, thanks. Guennadi, can you please confirm that
> this patch fixes your problem?

Yes, it does. Also tested with i2c bus debugging on and with interrupting 
hwclock, thereby messages

I2C: Interrupted

come, but the controller stays functional. Looks good so far:-)

Acked-by: G. Liakhovetski <g.liakhovetski at gmx.de>

Thanks
Guennadi
---
Guennadi Liakhovetski


More information about the Linuxppc-embedded mailing list