[PATCH 2.6.19] enable watchdog device on mpc834x platforms

Kumar Gala galak at kernel.crashing.org
Fri Dec 15 03:05:28 EST 2006


On Dec 14, 2006, at 10:01 AM, Pieter-Jan Busschaert wrote:

>> Two things about this patch:
>> 1. We've actively avoid taking non-bug fix patches to arch/ppc as we
>> try to move people over to arch/powerpc.
>> 2. You can't hard code freq in the platform data like that.  It's
>> expected to be the bus frequency the device is running at.
>
> The frequency is only used once in the driver to printk the
> watchdog-timeout in seconds. It doesn't affect the functionallity in
> any way. I looked at ways to get the cpu frequency dynamically in
> there, but didn't find a simple way to do it.

It does, in that the drive reports it on a WDIOC_GETTIMEOUT to user  
space.  (See how we use timeout_sec).

> But, because of your first comment, I suppose this patch will never
> enter the linux kernel, even if I get the frequency dynamically?

Most likely, but its still good to have the patches on the list for  
people to pull if they need them.

- k



More information about the Linuxppc-embedded mailing list