[PATCH] add big endian version of ld_/st_ IO access macros and convert main 8xx code to use it

Benjamin Herrenschmidt benh at kernel.crashing.org
Thu Sep 8 10:28:52 EST 2005


On Wed, 2005-09-07 at 20:03 -0300, Marcelo Tosatti wrote:
> Hi,
> 
> The following patch adds big endian version of ld_/st_ macros 
> and converts core 8xx code to use them.
> 
> Other than making IO accesses explicit (which is a plus for
> readability), a common set of macros provides a unified place for the
> volatile flag to constraint compiler code reordering.
> 
> There are several unlucky places at the moment which lack the 
> volatile flag.

I'm not fan of the approach. You should use in_/out_ macros for IOs. If
you don't need eieio on 8xx , then just #ifdef it out of the
implementation of these.

Ben.





More information about the Linuxppc-embedded mailing list