[PATCH kernel] cxl: Remove unused include

[Alexey Kardashevskiy]

On 28/09/2018 22:46, Michael Ellerman wrote:
> Alexey Kardashevskiy <aik at ozlabs.ru> writes:
>> The included opal.h gives a wrong idea that CXL makes PPC OPAL calls
>> while it does not so let's remote it.
> 
> But it does use eg.
> 
>   OPAL_PHB_CAPI_MODE_SNOOP_ON
>   OPAL_PHB_CAPI_MODE_CAPI
> 
> Which come from opal-api.h via opal.h.
> 
> So you should at least include opal-api.h.


I'd say that since it includes pnv-pci.h (and this is why this patch
compiles), it should be a different set of values for powernv (which
would map 1:1 to OPAL_PHB_xxx). The powernv platform knowledge is
already intimate enough for a driver to have. Dunno, I found this opal.h
inclusion confusing, that's all.



> 
> cheers
> 
>> diff --git a/drivers/misc/cxl/pci.c b/drivers/misc/cxl/pci.c
>> index b66d832..8cbcbb7 100644
>> --- a/drivers/misc/cxl/pci.c
>> +++ b/drivers/misc/cxl/pci.c
>> @@ -17,7 +17,6 @@
>>  #include <linux/pci.h>
>>  #include <linux/of.h>
>>  #include <linux/delay.h>
>> -#include <asm/opal.h>
>>  #include <asm/msi_bitmap.h>
>>  #include <asm/pnv-pci.h>
>>  #include <asm/io.h>
>> -- 
>> 2.11.0

-- 
Alexey