[PATCH v5 4/5] KVM: PPC: Alow kvmppc_get_last_inst() to fail

mihai.caraman at freescale.com mihai.caraman at freescale.com
Wed Jul 23 20:06:56 EST 2014

> > Right. With this do you acknowledge that v5 (definitely overwritten
> approach)
> > is ok?
> I think I'm starting to understand your logic of v5. You write
> fetch_failed into *inst unswapped if the fetch failed.

  - don't swap when load fails" :)

> I think that's ok, but I definitely do not like the code flow - it's too
> hard to understand at a glimpse. Just rewrite it to swab at local
> variable level, preferably with if()s and comments what this is about and
> have a single unconditional *inst = fetched_inst; at the end of the
> function.

I will incorporate these change requests into v6.


More information about the Linuxppc-dev mailing list