[PATCH 6/6] powerpc/powernv: Fix little endian issues in OPAL dump code

Vasant Hegde hegdevasant at linux.vnet.ibm.com
Wed Apr 23 14:36:50 EST 2014

On 04/23/2014 03:01 AM, Anton Blanchard wrote:
> Hi,
>> -int64_t opal_dump_info(uint32_t *dump_id, uint32_t *dump_size);
>> -int64_t opal_dump_info2(uint32_t *dump_id, uint32_t *dump_size, uint32_t *dump_type);
>> +int64_t opal_dump_info(__be32 *dump_id, __be32 *dump_size);
>> +int64_t opal_dump_info2(__be32 *dump_id, __be32 *dump_size, __be32 *dump_type);
>>   int64_t opal_dump_read(uint32_t dump_id, uint64_t buffer);
>>   int64_t opal_dump_ack(uint32_t dump_id);
>> Shouldn't we change above two functions as well ?
> No, there are no endian issues here because we pass the values via
> register. The only endian issues are for values we pass via pointer.


Thanks for the clarification..


More information about the Linuxppc-dev mailing list