[PATCH 0/3] of: dts: enable memory at 0 quirk for PPC32 only
leif.lindholm at linaro.org
Sat Apr 19 10:36:34 EST 2014
On Fri, Apr 18, 2014 at 04:28:17PM -0500, Rob Herring wrote:
> >> > Apart from the current code permitting recreating a 15+ year old
> >> > firmware bug into completely new platform ports?
> >> I would prefer to see a "WARN_ON(!IS_ENABLED(CONFIG_PPC32));" added here.
> > In addition to, or instead of, the QUIRK ifdef?
> Instead of because I don't see how you handle the ARM board
> compatibility with the ifdef. (And please, no ifdef for that board).
Umm, according to my memory as well as my sent mail folder, I cc:d you
on v2 of part 3. Could you have a look at that, please?
A WARN_ON would still mean this ancient workaround for a specific ppc32
platform remains enabled on ~10 architectures that don't use it.
> >> Really, I would like to see quirks like this fixed up out of line from
> >> the normal flow somewhat like how PCI quirks are handled. So in this
> >> example, we would just add the missing property to the dtb for the
> >> broken platform before doing the memory scan. That does then require
> >> libfdt which is something I'm working on.
> > Getting rid of all this handling from generic code would clearly be
> > preferable. Is that code going in in the near future, or could we add
> > the quirk as a stopgap?
> Some sort of quirk infrastructure is not going to happen soon. It's
> just an idea bouncing in my head ATM.
> > What would be the effect of the UEFI code adding all its memblocks,
> > minus the reserved areas, and then the DT code doing a memblock_add
> > of all RAM (including reserved areas)? Would memblock_reserve()s on
> > the protected regions suffice to prevent crazy stuff from happening?
> So use UEFI to add the memory, but then add reserved areas with DT?
No, to add memory and reserved areas based on UEFI memory map.
And then add any memory at 0/!type nodes as well, if they're left around.
> I'm not sure I follow, but even if I did I don't know memblock code
> well enough to say what it would do.
If we did end up with stray memory at 0/!type nodes, we could initialise
memblock multiple times with overlapping but incompatible areas.
And I don't know if that would be a problem. Which makes me a little
More information about the Linuxppc-dev