[PATCH 0/3] of: dts: enable memory at 0 quirk for PPC32 only
robherring2 at gmail.com
Sat Apr 19 07:28:17 EST 2014
On Fri, Apr 18, 2014 at 3:13 PM, Leif Lindholm <leif.lindholm at linaro.org> wrote:
> On Fri, Apr 18, 2014 at 10:37:58AM -0500, Rob Herring wrote:
>> >> But why do you need this?
>> > Apart from the current code permitting recreating a 15+ year old
>> > firmware bug into completely new platform ports?
>> I would prefer to see a "WARN_ON(!IS_ENABLED(CONFIG_PPC32));" added here.
> In addition to, or instead of, the QUIRK ifdef?
Instead of because I don't see how you handle the ARM board
compatibility with the ifdef. (And please, no ifdef for that board).
>> Really, I would like to see quirks like this fixed up out of line from
>> the normal flow somewhat like how PCI quirks are handled. So in this
>> example, we would just add the missing property to the dtb for the
>> broken platform before doing the memory scan. That does then require
>> libfdt which is something I'm working on.
> Getting rid of all this handling from generic code would clearly be
> preferable. Is that code going in in the near future, or could we add
> the quirk as a stopgap?
Some sort of quirk infrastructure is not going to happen soon. It's
just an idea bouncing in my head ATM.
>> > Because the UEFI stub for arm/arm64 needs to delete all of the "memory"
>> > nodes from the DT. And it would be nice to at least not have to compile
>> > the "and also delete anything called memory at 0" into the arm64 image. Or
>> > any image not including support for affected platforms.
>> I don't see why you would handle that in the EFI stub. Given our lack
>> of validation, I can see there is a chance this happens but I think it
>> is pretty small. Given we only have a ARM board, I'd say we are doing
>> surprisingly well.
> I'm not too bothered personally, but Mark Rutland handed me a patch to
> improve the memory node handling in the stub, and he seemed to really
> want this there. You guys can fight it out :)
Simply put, we shouldn't put work-arounds in new code for new platforms.
> What would be the effect of the UEFI code adding all its memblocks,
> minus the reserved areas, and then the DT code doing a memblock_add
> of all RAM (including reserved areas)? Would memblock_reserve()s on
> the protected regions suffice to prevent crazy stuff from happening?
So use UEFI to add the memory, but then add reserved areas with DT?
I'm not sure I follow, but even if I did I don't know memblock code
well enough to say what it would do.
More information about the Linuxppc-dev