[PATCH] powerpc/85xx: Add OCA4080 board support

Scott Wood scottwood at freescale.com
Wed Apr 16 03:15:01 EST 2014


On Tue, 2014-04-15 at 13:24 +0200, Martijn de Gouw wrote:
> On 04/15/2014 12:28 AM, Scott Wood wrote:
> > On Mon, 2014-04-14 at 14:35 +0200, Martijn de Gouw wrote:
> >> +	lbc: localbus at ffe124000 {
> >> +		reg = <0xf 0xfe124000 0 0x1000>;
> >> +		ranges = <0 0 0xf 0xef800000 0x800000>;
> >> +
> >> +		flash at 0,0 {
> >> +			#address-cells = <1>;
> >> +			#size-cells = <1>;
> >> +			compatible = "cfi-flash";
> >> +			reg = <0 0 0x00800000>;
> >> +			bank-width = <2>;
> >> +			device-width = <2>;
> >> +			partition at rcw {
> >> +				label = "rcw";
> >> +				reg = <0x00000000 0x00020000>;
> >> +			};
> >> +			partition at fman-ucode {
> >> +				label = "fman-ucode";
> >> +				reg = <0x00020000 0x00020000>;
> >> +			};
> >> +			partition at user {
> >> +				label = "user";
> >> +				reg = <0x00040000 0x00680000>;
> >> +			};
> >> +			partition at env0 {
> >> +				label = "env0";
> >> +				reg = <0x006c0000 0x00020000>;
> >> +			};
> >> +			partition at env1 {
> >> +				label = "env1";
> >> +				reg = <0x006e0000 0x00020000>;
> >> +			};
> >> +			partition at u-boot {
> >> +				label = "u-boot";
> >> +				reg = <0x00700000 0x00080000>;
> >> +			};
> >> +			partition at u-boot-backup {
> >> +				label = "u-boot-backup";
> >> +				reg = <0x00780000 0x00080000>;
> >> +			};
> >
> > These are not valid unit addresses.  Regardless, please don't put
> > partition info in the dts.
> 
> How is this different than the partitions defined in i.e. p4080ds.dts?

If you mean the unit addresses, they're supposed to be hex numbers that
match reg.  If you mean why are they there at all in p4080ds.dts, a lot
of existing trees have them but it's bad to mix configuration in with
hardware description and we're discouraging putting partitions in new
dts files.  It would be nice to clean up the old dts files as well,
though I'm concerned about people who are currently relying on them.
OTOH I'm also concerned about users for whom the dts partitions don't
match reality...

> Of course I can remove them from the dts, but where should they be defined?

Either use mtdparts on the kernel command line, or have U-Boot generate
the partition nodes at runtime based on the mtdparts environment
variable (there is already code for this).

-Scott




More information about the Linuxppc-dev mailing list