[PATCH v2 3/3] powerpc/85xx: Add C293PCIE board support

[Scott Wood]

On 07/25/2013 09:41:19 PM, Po Liu wrote:
> +		partition at 1900000 {
> +			/* 7MB for User Area */
> +			reg = <0x01900000 0x00700000>;
> +			label = "NAND User area";
> +		};
> +
> +		partition at 2000000 {
> +			/* 96MB for Root File System */
> +			reg = <0x02000000 0x06000000>;
> +			label = "NAND Root File System";
> +		};
> +
> +		partition at 8000000 {
> +			/* 3968MB for Others */
> +			reg = <0x08000000 0xF8000000>;
> +			label = "NAND Others";
> +		};

Again, what is the difference between "user area" and "others"?  I'm  
not even sure why it needs to be separate from "root file system", but  
at least the root filesystem should be larger given the size of the  
overall flash.

Also please use lowercase for hex.

> +	};
> +
> +	cpld at 2,0 {
> +		#address-cells = <1>;
> +		#size-cells = <1>;
> +		compatible = "fsl,c293pcie-cpld";
> +		reg = <0x2 0x0 0x20>;
> +	};

Remove #address-cells/#size-cells

> +			partition at 580000 {
> +				/* 10.5MB for Compressed RFS Image */
> +				reg = <0x00580000 0x00a80000>;
> +				label = "SPI Flash Compressed RFSImage";
> +			};

Space before "Image".  Why specifiy that it's compressed, versus some  
other filesystem type?

-Scott