[PATCH powerpc] Fake NUMA emulation for PowerPC (Take 3)
balbir at linux.vnet.ibm.com
Wed Jan 30 00:50:19 EST 2008
* Michael Ellerman <michael at ellerman.id.au> [2008-01-30 00:04:58]:
> Why do you check !p after assigning to nid? I assume it's because we
> might have reached the end of the command line, ie. p == NULL, but we're
> still adding memory to the last node? If so it's a it's a little subtle
> and deserves a comment I think.
The reason that we check for !p after assigning node id is that, in
case we create fake NUMA nodes, we want nid to be the fake numa node
id and not the real node id or in the non NUMA case, node id 0.
The if (!p) checks to see if we do have more arguments to parse.
> Otherwise this looks pretty good.
> Michael Ellerman
> OzLabs, IBM Australia Development Lab
> wwweb: http://michael.ellerman.id.au
> phone: +61 2 6212 1183 (tie line 70 21183)
> We do not inherit the earth from our ancestors,
> we borrow it from our children. - S.M.A.R.T Person
Linux Technology Center
More information about the Linuxppc-dev