[PATCH] Fake NUMA emulation for PowerPC (Take 2)
balbir at linux.vnet.ibm.com
Mon Jan 28 02:01:47 EST 2008
* Paul Mackerras <paulus at samba.org> [2008-01-27 22:55:43]:
> Balbir Singh writes:
> > Here's a better and more complete fix for the problem. Could you
> > please see if it works for you? I tested it on a real NUMA box and it
> > seemed to work fine there.
> There are a couple of other changes in behaviour that your patch
> introduces, and I'd like to understand them better before taking the
> patch. First, with your patch we don't set nodes online if they end
> up having no memory in them because of the memory limit, whereas
> previously we did. Secondly, in the case where we don't have NUMA
> information, we now set node 0 online after adding each LMB, whereas
> previously we only set it online once.
> If in fact these changes are benign, then your patch description
> should mention them and explain why they are benign.
Yes, they are. I'll try and justify the changes with a good detailed
changelog. If people prefer it, I can hide fake NUMA nodes under a
config option, so that it does not come enabled by default.
Thanks for keeping me honest.
> Linuxppc-dev mailing list
> Linuxppc-dev at ozlabs.org
Linux Technology Center
More information about the Linuxppc-dev