[PATCH] [POWERPC] MPC8360E-RDK: device tree, board file and defconfig

[Stephen Rothwell]

Hi Anton,

On Thu, 24 Jan 2008 16:29:01 +0300 Anton Vorontsov <avorontsov at ru.mvista.com> wrote:
>
> On Thu, Jan 24, 2008 at 01:22:01PM +1100, Stephen Rothwell wrote:
> > On Wed, 23 Jan 2008 23:45:07 +0300 Anton Vorontsov <avorontsov at ru.mvista.com> wrote:
> > >
> > > +++ b/arch/powerpc/platforms/83xx/mpc836x_rdk.c
> > > +static int __init mpc836x_rdk_declare_of_platform_devices(void)
> > > +{
> > > +	const struct of_device_id mpc836x_rdk_ids[] = {
> > 
> > Please change this to static, __initdata and not const, thanks. These
> > arrays are usually defined outside a function, but that is not really a
> > problem.
> 
> Pity... we don't need these _ids anywhere outside that function. But
> looking into objdump output I see the problem now.
> 
> Will change this back, thanks.
> 
> > > +static void __init mpc836x_rdk_setup_arch(void)
> > > +{
> > > +	struct device_node *np;
> > 
> > !defined(CONFIG_PCI) && !defined(CONFIG_QUICC_ENGINE) will produce a
> > warning here.
> 
> Good catch, thanks.
> 
> > > +	if (ppc_md.progress)
> > > +		ppc_md.progress("mpc836x_rdk_setup_arch()", 0);
> > > +
> > > +#ifdef CONFIG_PCI
> > > +	for_each_compatible_node(np, "pci", "fsl,mpc8349-pci")
> > > +		mpc83xx_add_bridge(np);
> > > +#endif
> > > +
> > > +#ifdef CONFIG_QUICC_ENGINE
> > > +	qe_reset();
> > > +
> > > +	np = of_find_compatible_node(NULL, NULL, "fsl,qe-pario");
> > > +	if (!np) {
> > > +		pr_warning("QE PIO not initialized!\n");
> > > +		return;
> > 
> > You need an of_node_put(np) before the return.
> 
> Hm, really? I think I don't. But if you insist... :-)

Sorry, I don't know what I was thinking - of course you don't need it.

-- 
Cheers,
Stephen Rothwell                    sfr at canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20080125/8cf6a5be/attachment.pgp>