[PATCH 3/4 v4] POWERPC: Add initial iomega StorCenter board port.

Kumar Gala galak at kernel.crashing.org
Thu Jan 24 12:54:29 EST 2008


On Jan 23, 2008, at 6:50 PM, Stephen Rothwell wrote:

> Hi Jon,
>
> On Wed, 23 Jan 2008 12:42:50 -0600 Jon Loeliger <jdl at jdl.com> wrote:
>>
>> +++ b/arch/powerpc/platforms/embedded6xx/storcenter.c
>> +static void __init storcenter_init_IRQ(void)
>> +{
>> +	struct mpic *mpic;
>> +	struct device_node *dnp;
>> +	const void *prop;
>> +	int size;
>> +	phys_addr_t paddr;
>> +
>> +	dnp = of_find_node_by_type(NULL, "open-pic");
>> +	if (dnp == NULL)
>> +		return;
>> +
>> +	prop = of_get_property(dnp, "reg", &size);
>> +	if (prop == NULL)
>> +		return;
>
> You need an of_node_put(dnp) before you return.

Fixed up by your friendly maintainer.

- k



More information about the Linuxppc-dev mailing list