[PATCH] [POWERPC] Move RapidIO support code from arch/ppc

Kumar Gala galak at kernel.crashing.org
Thu Jan 24 10:00:41 EST 2008


On Jan 23, 2008, at 4:40 PM, Stephen Rothwell wrote:

> Hi Kumar,
>
> On Wed, 23 Jan 2008 06:38:29 -0600 (CST) Kumar Gala <galak at kernel.crashing.org 
> > wrote:
>>
>> +++ b/arch/ppc/platforms/85xx/mpc85xx_ads_common.c
>> @@ -190,6 +188,7 @@ mpc85xx_exclude_device(u_char bus, u_char devfn)
>> #endif /* CONFIG_PCI */
>>
>> #ifdef CONFIG_RAPIDIO
>> +extern void mpc85xx_rio_setup(int law_start, int law_size);
>
> Ooops! This should be in a header file, of course.
>
>> +++ b/arch/ppc/platforms/85xx/stx_gp3.c
>> @@ -270,6 +269,7 @@ int mpc85xx_exclude_device(u_char bus, u_char  
>> devfn)
>> #endif /* CONFIG_PCI */
>>
>> #ifdef CONFIG_RAPIDIO
>> +extern void mpc85xx_rio_setup(int law_start, int law_size);
>
> And again.
>
> I guess this is just temporary in which case we can probably live with
> it.  But do not forget to fix it up.
>
>> +++ b/arch/ppc/platforms/85xx/tqm85xx.c
>> @@ -309,6 +308,7 @@ int mpc85xx_exclude_device(u_char bus, u_char  
>> devfn)
>> #endif /* CONFIG_PCI */
>>
>> #ifdef CONFIG_RAPIDIO
>> +extern void mpc85xx_rio_setup(int law_start, int law_size);
>
> Third time lucky?   :-)

They were in a header file, however in moving the code over the header  
ends up in arch/powerpc/sysdev/fsl_rio.h.  I don't think there is a  
simple way to include that in arch/ppc code today (and I don't want to  
invent one).

My goal is to just kill 85xx for arch/ppc.

- k



More information about the Linuxppc-dev mailing list