[PATCH v6] [POWERPC] Add LED driver for Promess Motion-PRO board.

Stephen Rothwell sfr at canb.auug.org.au
Thu Jan 24 09:34:52 EST 2008


Hi Marian,

On Wed, 23 Jan 2008 13:12:19 +0100 Marian Balakowicz <m8 at semihalf.com> wrote:
>
> +	label = of_get_property(op->node, "label", NULL);
> +	if (label == NULL) {
> +		printk(KERN_ERR __FILE__ ": "
> +			"No label property provided for LED %s\n",
> +			op->node->full_name);
> +		err = -EINVAL;
> +		goto err_free;

You need an iounmap(mpled->gpt) here - or preferably jump to the one in
the error path below.

-- 
Cheers,
Stephen Rothwell                    sfr at canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20080124/e34ed7ea/attachment.pgp>


More information about the Linuxppc-dev mailing list